Clean The Code
Challenge
Find the right Design Pattern coding style, define it and clean the code !
Difficulty (1-5)
3
Mission
There is a bunch to do to clean the code.
A brief history of the past few months
Many developers contributed on the app. Our processes needed to be improved. The first step was to put some strict code formatting rules. These are available HERE. We decided to control the contribution to the production code. So we established as a good rule of thumb that a pull request would be accepted to the only condition that the code was peer-reviewed by a minimum of 2 echTopians. We might say that it happened that the code was merged because we didn't obtain the quorum of 2 in a reasonable amount of time.
But,
even if we are improving in following these guide lines, different layers of code contributions sediment together without any solution of coherence. The formatting code rules are followed but the coding styles are different because no strict design pattern choice has ever been taken.
Your mission will be to find one, argument it and implement it.
RESSOURCES
There are some intense debate about how to find the right design pattern in the Android settings : MVP, MVC or whatever. It seems that MVP is getting some string supporters, especially Google.
We strongly suggest the reader to get to the entry point to Google's framework. Examples of android-focuses MVP can be found HERE.
REPOS
Pull-requests submissions to REPO
REWARD
- Residency in our Head Quarters located at the very center of Paris, on le Parvis de Notre Dame (hosting and breakfast )
- DevBox USB keys at your name, T-shirts and other Goodies
- Mention on our Hall of fame of open sources dudes
SUDOERS
@nowami [email protected]
ECHPERTS
on github aka @gregsadetsky, @loic-fejoz